[PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Etienne Bergeron via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 11:06:00 PDT 2016


etienneb added a comment.

In http://reviews.llvm.org/D20714#445911, @Eugene.Zelenko wrote:

> There is a way to tell IWYU about compound headers with pragmas <https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md>. I also suggested to make this possible via file with compound headers list.
>
> But person who knows LLVM/Clang code base better then me should define such headers.


I spent time thinking about that problem months ago and I've found so many strange cases.
It seems an easy problem on the surface, but when you dig you realized there is so many corner cases.

My comment on this patch is not related to the tool or how the tool is working.
It's more a question about whether or not we should "compound" some headers you expanded.
Most of the include you added are right and must be present.

A general question on your tool is: can we specify the IWYU pragma somewhere else than in the code.
I'm not in favor of building xmas tree with your header files.

  IWYU pragma:

I don't know how common they will be.


Repository:
  rL LLVM

http://reviews.llvm.org/D20714





More information about the cfe-commits mailing list