[PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

Bruno Cardoso Lopes via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 10:19:46 PDT 2016


bruno added inline comments.

================
Comment at: test/PCH/include-timestamp.cpp:5
@@ +4,3 @@
+// Check timestamp is included by default.
+// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %S/Inputs/include-timestamp-pch.h
+// RUN: touch %S/Inputs/include-timestamp.h
----------------
Can you also check the timestamp by looking at llvm-bcanalyzer output (assuming the tool outputs such info)?

================
Comment at: test/PCH/include-timestamp.cpp:7
@@ +6,3 @@
+// RUN: touch %S/Inputs/include-timestamp.h
+// RUN: sleep 1
+// RUN: not %clang_cc1 -include-pch %t %s 2>&1 | FileCheck -check-prefix=CHECK-TIMESTAMP %s
----------------
Why use `sleep 1` here?

================
Comment at: test/PCH/include-timestamp.cpp:16
@@ +15,3 @@
+
+#include "Inputs/include-timestamp.h"
+
----------------
It make sense for the context of this patch, but if http://reviews.llvm.org/D20243 gets in, you should re-use the same headers you're adding there.


http://reviews.llvm.org/D20867





More information about the cfe-commits mailing list