[PATCH] D16948: [libcxx] Filesystem TS -- Complete

David Majnemer via cfe-commits cfe-commits at lists.llvm.org
Tue May 31 08:48:43 PDT 2016


majnemer added inline comments.

================
Comment at: src/experimental/operations.cpp:128-129
@@ +127,4 @@
+bool stat_equivalent(struct ::stat& st1, struct ::stat& st2) {
+    return (st1.st_dev == st2.st_dev && st1.st_ino == st2.st_ino);
+}
+
----------------
It is possible for `st_ino` to wrap around while the machine is still running.
I'd mix `st_gen` into the comparison if we are running under one of the BSDs or Darwin.

Linux has a `FS_IOC_GETVERSION` ioctl but it requires a file descriptor.  Maybe such heroics are not worth it.


http://reviews.llvm.org/D16948





More information about the cfe-commits mailing list