[PATCH] D20388: AMDGPU: Fix supported CL features

Jan Vesely via cfe-commits cfe-commits at lists.llvm.org
Sun May 29 10:44:59 PDT 2016


jvesely added inline comments.

================
Comment at: test/Misc/r600.languageOptsOpenCL.cl:4
@@ +3,3 @@
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown -target-cpu cypress
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown -target-cpu turks -DTURKS
+// RUN: %clang_cc1 -x cl -cl-std=CL1.1 %s -verify -triple r600-unknown-unknown -target-cpu cayman
----------------
arsenm wrote:
> We should probably add builtin device macros for these
When we ran into similar problem while adding fma. We opted for feature macro(__HAS_FMAF__) instead of device macro. I suppose I can add __HAS_FP64__, but it won't have many uses since everyone checks for cl_khr_fp64.


Repository:
  rL LLVM

http://reviews.llvm.org/D20388





More information about the cfe-commits mailing list