[PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

Dmitry Polukhin via cfe-commits cfe-commits at lists.llvm.org
Thu May 26 06:33:59 PDT 2016


On Thu, May 26, 2016 at 12:41 AM, David Majnemer <david.majnemer at gmail.com>
wrote:

> In http://reviews.llvm.org/D18035#434095, @DmitryPolukhin wrote:
>
> > One more friendly ping...... :(
>
> I think the best way to make progress on this is to refactor this patch
> along the lines @rsmith suggested back on May 3.
>

To be honest I still don't understand what is the key difference between
these two approaches. Both assume that compiler mangles something twice:
one for collecting implicit abi_tags without outputting name to real stream
and once more time mangling name for real with implicit tags collected on
previous stage. I tested my patch on Richard's example and explained why it
works as it should be.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160526/93fd5218/attachment.html>


More information about the cfe-commits mailing list