[PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

Akira Hatanaka via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 13:53:48 PDT 2016


ahatanak marked 7 inline comments as done.

================
Comment at: lib/AST/Type.cpp:1282
@@ -1277,1 +1281,3 @@
+}
+
 Optional<ArrayRef<QualType>> Type::getObjCSubstitutions(
----------------
I added getTypePtr() because the code didn't compile.

================
Comment at: lib/CodeGen/CGObjC.cpp:901
@@ -903,1 +900,3 @@
+    uint64_t ivarSize = getContext().toBits(strategy.getIvarSize());
+    llvm::Type *bitcastType = llvm::Type::getIntNTy(getLLVMContext(), ivarSize);
     bitcastType = bitcastType->getPointerTo(); // addrspace 0 okay
----------------
I've only changed ivarSize. I can change the variable names defined below (RetTy and RetTySize) too if that is necesasry.


http://reviews.llvm.org/D20407





More information about the cfe-commits mailing list