[PATCH] D20089: Adding a TargetParser for AArch64

jojo.ma via cfe-commits cfe-commits at lists.llvm.org
Sun May 22 23:40:08 PDT 2016

jojo added a comment.

> There is an awful lot of duplication/passing through to another class in this, it strikes me that this whole thing could benefit from some level of inheritance. I think it would be good to have a base class that defines the interface and have both ARM/AArch64 (and any other architectures that want to use this in the future) implement this interface. That way all of this code can be called generically from clang/wherever.

Dear Bradley,

Thank you very much for such good advice.
Making the TargetParser into class-base design will need  large changes.I think it maybe better to do that in a steady way.
So we can do it step by step.Just make a similar one for aarch64 at first,then make both of them into class.
what's your opinion?



More information about the cfe-commits mailing list