[PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

[Peter Collingbourne via cfe-commits]

pcc added inline comments.

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3477
@@ -3473,1 +3476,3 @@
+    InitExpr =
+        DBuilder.createConstantValueExpression(Init.getInt().getExtValue());
   GV.reset(DBuilder.createGlobalVariable(
----------------
aprantl wrote:
> pcc wrote:
> > aprantl wrote:
> > > Are we regressing floating point constants here?
> > It looks like we never really supported floating point constants in the DWARF output. I can only see support for integer constants:
> > http://llvm-cs.pcc.me.uk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp#192
> Looking at http://llvm-cs.pcc.me.uk/test/DebugInfo/X86/float_const.ll we at least do to some degree :-)
That isn't a global variable test case though, is it?


http://reviews.llvm.org/D20415