[PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

Adrian Prantl via cfe-commits cfe-commits at lists.llvm.org
Fri May 20 09:34:25 PDT 2016

aprantl added inline comments.

Comment at: lib/CodeGen/CGDebugInfo.cpp:3393
@@ +3392,3 @@
+        DContext, FieldName, LinkageName, Unit, LineNo, FieldTy,
+        Var->hasInternalLinkage(), nullptr, nullptr);
+    Var->addDebugInfo(GV);
aprantl wrote:
> Is there a good reason for not changing the DIBuilder interface to drop the global field?
Sorry about the confusion, I should have read the other patch first. This has morphed into the DIExpression. That's fine!


More information about the cfe-commits mailing list