[PATCH] D20422: [MSVC2015] dllexport for defaulted special class members

Dmitry Polukhin via cfe-commits cfe-commits at lists.llvm.org
Thu May 19 22:33:36 PDT 2016

DmitryPolukhin added inline comments.

Comment at: lib/Sema/SemaDeclCXX.cpp:13111
@@ -13090,3 +13110,3 @@
       llvm_unreachable("Invalid special member.");
   } else {
rnk wrote:
> Can we add `if (InClassDef) ActOnFinishInlineFunctionDef(MD);` here instead? If the decl doesn't have dllexport, we will just defer it until its referenced, which seems OK.
We can move this check here but condition has to be more complicated because MSVC2015 doesn't export trivial defaulted c-tors even if they were explicitly declared dllexport, see my check on line 4822.


More information about the cfe-commits mailing list