[PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

Akira Hatanaka via cfe-commits cfe-commits at lists.llvm.org
Thu May 19 19:17:02 PDT 2016

ahatanak added a comment.

In http://reviews.llvm.org/D20407#433915, @rjmccall wrote:

> _Atomic is functionally a type qualifier and should be removed in Sema when computing the result type of the getter and the parameter type of the setter.  That is, if the user declares a property of type _Atomic(_Bool), we should pretend that the property has type _Bool when creating the getter and setter.

That sounds like a more principled way to fix the problem. We'll have to remove _Atomic from return types of normal functions too, not just objective-c getters and setters, because otherwise programs like this won't compile:

  _Atomic(_Bool) foo1() {
    A *a = [A new];
    return a.p;


More information about the cfe-commits mailing list