[PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Thu May 19 18:43:10 PDT 2016

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Sorry for the delay, this all LGTM. Do you need someone to commit it for you?

Comment at: lib/Sema/SemaTemplate.cpp:2082-2085
@@ +2081,6 @@
+    // If the Index is out of bounds, the program is ill-formed.
+    //
+    // TODO:
+    // This is not actually mandated by the standard, of course, so does it
+    // have its place here?
+    TemplateArgument IndexArg = Converted[0], Ts = Converted[1];
This is fine; we get to specify how our extensions work, so we can say that an `Index` that's out of bounds is ill-formed.


More information about the cfe-commits mailing list