[PATCH] D20422: [MSVC2015] dllexport for defaulted special class members

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Thu May 19 11:56:25 PDT 2016

rnk added inline comments.

Comment at: lib/Sema/SemaDeclCXX.cpp:4814
@@ -4813,3 +4813,3 @@
         // we have a definition.
         auto *CXXC = dyn_cast<CXXConstructorDecl>(MD);
         if ((MD->isMoveAssignmentOperator() ||
nit, can you rename this Ctor? I definitely know that that is, but not necessarily CXXC.

Comment at: lib/Sema/SemaDeclCXX.cpp:13111
@@ -13090,3 +13110,3 @@
       llvm_unreachable("Invalid special member.");
   } else {
Can we add `if (InClassDef) ActOnFinishInlineFunctionDef(MD);` here instead? If the decl doesn't have dllexport, we will just defer it until its referenced, which seems OK.


More information about the cfe-commits mailing list