[PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Wed May 18 08:52:01 PDT 2016

alexfh added inline comments.

Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:187
@@ +186,3 @@
+                                   "}",
+                                   unresolvedLookupExpr(), true,
+                                   "-fno-delayed-template-parsing"));
thakis wrote:
> Doesn't referencing `bar()` after it's defined help too? If not, this is cool too -- maybe add a `/*ExpectMatch=*/` in front of `true` so it's clear what the true means.
Yes, please add an argument comment and a FIXME to the code that is known to be broken with delayed template parsing. Thanks!



More information about the cfe-commits mailing list