[PATCH] D20366: [ASTMatcher] Make dump_ast_matchers.py executable.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed May 18 07:55:08 PDT 2016

aaron.ballman added a comment.

In http://reviews.llvm.org/D20366#433103, @hokein wrote:

> In http://reviews.llvm.org/D20366#433054, @aaron.ballman wrote:
> > Yeah, I'm not certain either (I've never used phab for reviewing this sort of thing). I would prefer this to be 0744 so that it is not group or world executable.
> No idea on this now. I tried `chmod 744` either in `git.core.filemode=true` or in  `git.core.filemode=false`, the git always shows 755 in the commit :(.

It sounds like this may be a git thing and what you really want is svn:executable. However, the documentation doesn't specify *what* permissions that file winds up with (http://svnbook.red-bean.com/en/1.7/svn.advanced.props.file-portability.html#svn.advanced.props.special.executable).

What's the harm in leaving the props at 0644?


More information about the cfe-commits mailing list