[PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.
Alexander Kornienko via cfe-commits
cfe-commits at lists.llvm.org
Wed May 18 07:46:22 PDT 2016
alexfh added a comment.
In http://reviews.llvm.org/D20360#432882, @aaron.ballman wrote:
> In http://reviews.llvm.org/D20360#432878, @alexfh wrote:
> > In http://reviews.llvm.org/D20360#432874, @aaron.ballman wrote:
> > > The changes to docs/tools/dump_ast_matchers.py look to be spurious, can they be reverted?
> > The script should be executable, so the change looks fine to me.
> World executable? That's a bit presumptuous. ;-) 0744 may be fine, but 0755 does not seem correct to me.
> Regardless, I think that it should be a separate commit, not part of this one as a drive-by (it has security implications, and that deserves review).
Not sure there's any benefit (or any added security) in limiting execution bit to the owner. I've never seen files with 0744 permission mask and when I tried to find some on my machine, I only found a few CUPS binaries. In any case, svn:executable does not allow much customization: http://svnbook.red-bean.com/en/1.7/svn.advanced.props.file-portability.html#svn.advanced.props.special.executable
More information about the cfe-commits