[PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed May 18 05:05:33 PDT 2016

aaron.ballman added a comment.

In http://reviews.llvm.org/D20360#432878, @alexfh wrote:

> In http://reviews.llvm.org/D20360#432874, @aaron.ballman wrote:
> > The changes to docs/tools/dump_ast_matchers.py look to be spurious, can they be reverted?
> The script should be executable, so the change looks fine to me.

World executable? That's a bit presumptuous. ;-) 0744 may be fine, but 0755 does not seem correct to me.

Regardless, I think that it should be a separate commit, not part of this one as a drive-by (it has security implications, and that deserves review).


More information about the cfe-commits mailing list