[PATCH] D20326: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Wed May 18 01:35:53 PDT 2016

hokein marked an inline comment as done.

Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Move this node matcher to ASTMatcher.
+AST_MATCHER(Stmt, unresolvedLookupExpr) {
+  return isa<UnresolvedLookupExpr>(Node);
alexfh wrote:
> That's because we need a node matcher, not narrowing matcher. I guess, this should work:
>   const internal::VariadicAllOfMatcher<UnresolvedLookupExpr> unresolvedLookupExpr;
Yeah. But as the name indicates, `VariadicAllOfMatcher` is used internally in ASTMatcher, is it reasonable to use it here? I can't find such usage in clang-tidy side. 


More information about the cfe-commits mailing list