[PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 14:09:45 PDT 2016

alexfh added a comment.

In http://reviews.llvm.org/D19105#427046, @Prazek wrote:

> In http://reviews.llvm.org/D19105#426903, @alexfh wrote:
> > returning a bool from a function that is declared to return a typedef to an integral type that contains `bool` in its name (e.g. `LLVMBool`), and maybe some other cases.
> Isn't it LLVMBool issue?
> I won't have enough time to fix it, so I would prefer to comment fixit and only push warnings.

Whether we disable fixits or not, there seem to be too many false positives for the check to be useful. We should fix at least cases like `bool b; ... if (b == true) ...` and `bool b; ... b ^= true;`.


More information about the cfe-commits mailing list