[PATCH] D20325: Add ARM cdp intrinsics

Renato Golin via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 10:33:15 PDT 2016

rengolin added inline comments.

Comment at: include/clang/Basic/BuiltinsARM.def:55
@@ -54,3 +54,3 @@
 BUILTIN(__builtin_arm_mrc2, "UiUIiUIiUIiUIiUIi", "")
-BUILTIN(__builtin_arm_cdp, "vUiUiUiUiUiUi", "")
-BUILTIN(__builtin_arm_cdp2, "vUiUiUiUiUiUi", "")
+BUILTIN(__builtin_arm_cdp, "vUIiUIiUIiUIiUIiUIi", "")
+BUILTIN(__builtin_arm_cdp2, "vUIiUIiUIiUIiUIiUIi", "")
t.p.northover wrote:
> rengolin wrote:
> > I wonder why the old signature was wrong... probably because the docs weren't public and no one could really check whether they were right or not. I don't want to repeat the same mistake.
> The difference between "UIi" and "Ui" is that the fix requires a constant. A pretty obvious restriction even without a specification.
Ah, this makes sense. Looks like a good change in its own.



More information about the cfe-commits mailing list