r269780 - Tentatively enable -Wcast-calling-convention by default

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 09:50:46 PDT 2016

Author: rnk
Date: Tue May 17 11:50:45 2016
New Revision: 269780

URL: http://llvm.org/viewvc/llvm-project?rev=269780&view=rev
Tentatively enable -Wcast-calling-convention by default

In Chrome, this would have found two true positives around CreateThread
if we hadn't already fixed them while rolling out ASan. We didn't get
any other hits in Chrome. I'm curious to hear if this warning finds
anything in other projects.


Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=269780&r1=269779&r2=269780&view=diff
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Tue May 17 11:50:45 2016
@@ -6639,7 +6639,7 @@ def warn_function_def_in_objc_container
 def warn_cast_calling_conv : Warning<
   "cast between incompatible calling conventions '%0' and '%1'; "
   "calls through this pointer may abort at runtime">,
-  InGroup<DiagGroup<"cast-calling-convention">>, DefaultIgnore;
+  InGroup<DiagGroup<"cast-calling-convention">>;
 def note_change_calling_conv_fixit : Note<
   "consider defining %0 with the '%1' calling convention">;
 def warn_bad_function_cast : Warning<

More information about the cfe-commits mailing list