[PATCH] D20119: [libunwind] Improve unwinder stack usage

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 08:06:21 PDT 2016

rmaprath added inline comments.

Comment at: src/UnwindCursor.hpp:580
@@ -579,3 +605,1 @@
       _isSignalFrame(false) {
-  static_assert(sizeof(UnwindCursor<A, R>) < sizeof(unw_cursor_t),
-                "UnwindCursor<> does not fit in unw_cursor_t");
jroelofs wrote:
> Is there a good reason to move this static assert out to libunwind.cpp? ISTM it serves its purpose better here.
I removed this thinking there is already an assert in `libunwind.cpp` checking the same constraint. Didn't realize the latter assert was something I introduced in the patch!

Will fix.


More information about the cfe-commits mailing list