[PATCH] D20326: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 08:00:36 PDT 2016

alexfh added inline comments.

Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+  return isa<UnresolvedLookupExpr>(Node.getCallee());
I think, we should use a node matcher for `UnresolvedLookupExpr` and instead use `callExpr(callee(unresolvedLookupExpr().bind("something")))`.

Also, I would create the new matcher in the ASTMatchers.h right away, together with a test and docs. But if you want this patch to be in soon, feel free to move the matcher to the matchers library in a follow up.



More information about the cfe-commits mailing list