[PATCH] D20325: Add ARM cdp intrinsics

Renato Golin via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 06:39:31 PDT 2016

rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.

Please, re-submit this change once the documents have been made public.

Feel free to submit the assembly test to LLVM, using llc, on their own.


Comment at: include/clang/Basic/BuiltinsARM.def:55
@@ -54,3 +54,3 @@
 BUILTIN(__builtin_arm_mrc2, "UiUIiUIiUIiUIiUIi", "")
-BUILTIN(__builtin_arm_cdp, "vUiUiUiUiUiUi", "")
-BUILTIN(__builtin_arm_cdp2, "vUiUiUiUiUiUi", "")
+BUILTIN(__builtin_arm_cdp, "vUIiUIiUIiUIiUIiUIi", "")
+BUILTIN(__builtin_arm_cdp2, "vUIiUIiUIiUIiUIiUIi", "")
I wonder why the old signature was wrong... probably because the docs weren't public and no one could really check whether they were right or not. I don't want to repeat the same mistake.

Comment at: test/CodeGen/arm-coproc-intrinsics.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -Wall -triple thumbv7-eabi -target-cpu cortex-a8 -S -o - %s | FileCheck %s
Please, do not add assembly tests in Clang. This test should be in LLVM.



More information about the cfe-commits mailing list