[PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 04:58:48 PDT 2016

Anastasia added a comment.

Looking good already! I just have one general concern about committing 16K lines of code with no tests. But perhaps testing all the declarations isn't an option actually.

Could we at least have a test that includes the header and makes sure it's compiled successfully. Any thought's on this?

Also I can see that other headers are added to lib/Headers/CMakeLists.txt.


More information about the cfe-commits mailing list