[clang-tools-extra] r269278 - [clang-tidy] Ignore using-declarations defined in marcro in misc-unused-using-decls checks.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Thu May 12 03:00:49 PDT 2016


Author: hokein
Date: Thu May 12 05:00:49 2016
New Revision: 269278

URL: http://llvm.org/viewvc/llvm-project?rev=269278&view=rev
Log:
[clang-tidy] Ignore using-declarations defined in marcro in misc-unused-using-decls checks.

Reviewers: djasper

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D20197

Modified:
    clang-tools-extra/trunk/clang-tidy/misc/UnusedUsingDeclsCheck.cpp
    clang-tools-extra/trunk/test/clang-tidy/misc-unused-using-decls.cpp

Modified: clang-tools-extra/trunk/clang-tidy/misc/UnusedUsingDeclsCheck.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/UnusedUsingDeclsCheck.cpp?rev=269278&r1=269277&r2=269278&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/UnusedUsingDeclsCheck.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/UnusedUsingDeclsCheck.cpp Thu May 12 05:00:49 2016
@@ -35,6 +35,10 @@ void UnusedUsingDeclsCheck::check(const
     const auto *TargetDecl =
         Using->shadow_begin()->getTargetDecl()->getCanonicalDecl();
 
+    // Ignores using-declarations defined in macros.
+    if (TargetDecl->getLocation().isMacroID())
+      return;
+
     // Ignores using-declarations defined in class definition.
     if (isa<CXXRecordDecl>(TargetDecl->getDeclContext()))
       return;

Modified: clang-tools-extra/trunk/test/clang-tidy/misc-unused-using-decls.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/misc-unused-using-decls.cpp?rev=269278&r1=269277&r2=269278&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/misc-unused-using-decls.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/misc-unused-using-decls.cpp Thu May 12 05:00:49 2016
@@ -70,6 +70,14 @@ using n::UnusedFunc; // UnusedFunc
 using n::cout;
 using n::endl;
 
+#define DEFINE_INT(name)        \
+  namespace INT {               \
+  static const int _##name = 1; \
+  }                             \
+  using INT::_##name
+DEFINE_INT(test);
+#undef DEFIND_INT
+
 // ----- Usages -----
 void f(B b);
 void g() {




More information about the cfe-commits mailing list