[PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Thu May 12 00:40:20 PDT 2016


On Thu, May 12, 2016 at 9:22 AM Miklos Vajna <vmiklos at vmiklos.hu> wrote:

> vmiklos added a comment.
>
> Hi,
>
> > Also: should we add a check that the token of the source location we
> find actually has the old name?
>
>
> Hmm, how do I get the token at a specific SourceLocation? The best I found
> so far is SourceManager::getBuffer(), but that looks more like looking up
> raw bytes from the source file at a location, not a token.
>

Usually you'll want Lexer::getSourceText; that also gets the bytes from the
source file, but that's also what we really want to check.


>
> Thanks,
>
> Miklos
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D20150
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160512/3d093c90/attachment.html>


More information about the cfe-commits mailing list