r269224 - [tooling] Fix missing inline keyworkd, breaking build bot.

[Richard Smith via cfe-commits]

On Wed, May 11, 2016 at 1:09 PM, Etienne Bergeron via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Author: etienneb
> Date: Wed May 11 15:09:17 2016
> New Revision: 269224
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269224&view=rev
> Log:
> [tooling] Fix missing inline keyworkd, breaking build bot.
>
> Summary:
> The missing keyword "inline" is causing some buildbot to fail.
> The symbol is not available.
>
> see:
> http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/2281/
>
> Reviewers: rnk
>
> Subscribers: cfe-commits, klimek
>
> Differential Revision: http://reviews.llvm.org/D20180
>
> Modified:
>     cfe/trunk/include/clang/Tooling/FixIt.h
>
> Modified: cfe/trunk/include/clang/Tooling/FixIt.h
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Tooling/FixIt.h?rev=269224&r1=269223&r2=269224&view=diff
>
> ==============================================================================
> --- cfe/trunk/include/clang/Tooling/FixIt.h (original)
> +++ cfe/trunk/include/clang/Tooling/FixIt.h Wed May 11 15:09:17 2016
> @@ -40,27 +40,27 @@ inline SourceRange getSourceRange(const
>
>  /// \brief Returns the SourceRange of an given Node. \p Node is typically
> a
>  ///        'Stmt', 'Expr' or a 'Decl'.
> -template <typename T> SourceRange getSourceRange(const T &Node) {
> +template <typename T> inline SourceRange getSourceRange(const T &Node) {
>    return Node.getSourceRange();
>  }
>  } // end namespace internal
>
>  // \brief Returns a textual representation of \p Node.
>  template <typename T>
> -StringRef getText(const T &Node, const ASTContext &Context) {
> +inline StringRef getText(const T &Node, const ASTContext &Context) {
>    return internal::getText(internal::getSourceRange(Node), Context);
>  }
>
>  // \brief Returns a FixItHint to remove \p Node.
>  // TODO: Add support for related syntactical elements (i.e. comments,
> ...).
> -template <typename T> FixItHint createRemoval(const T &Node) {
> +template <typename T> inline FixItHint createRemoval(const T &Node) {
>    return FixItHint::CreateRemoval(internal::getSourceRange(Node));
>  }
>
>  // \brief Returns a FixItHint to replace \p Destination by \p Source.
>  template <typename D, typename S>
> -FixItHint createReplacement(const D &Destination, const S &Source,
> -                            const ASTContext &Context) {
> +inline FixItHint createReplacement(const D &Destination, const S &Source,
> +                                   const ASTContext &Context) {
>    return
> FixItHint::CreateReplacement(internal::getSourceRange(Destination),
>                                        getText(Source, Context));
>  }
>

This change doesn't make sense -- the 'inline' here is unnecessary, and
unrelated to the build bot failure (which is not complaining about any of
these functions). It looks like the problem is that libTooling.so isn't
being linked into libclangTidyMiscModule, due to a missing dependency in
clang-tools-extra/clang-tidy/misc/CMakeLists.txt.

Please revert this and instead add a dependency on libTooling to that
CMakeLists.txt file.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160511/d43ddad1/attachment-0001.html>