[PATCH] D19941: [tooling] FixItHint Tooling refactoring

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Wed May 11 01:26:54 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG. Thanks!


================
Comment at: unittests/Tooling/FixItTest.cpp:37
@@ +36,3 @@
+    EXPECT_EQ("foo(x, y)",
+              tooling::fixit::getText(CE->getSourceRange(), *Context));
+
----------------
Let's either put the tests in the `clang::tooling::<anonymous>` namespace (not common for unit tests in this specific directory, but nevertheless reasonable, imo) or add using declarations for `tooling::fixit::getText` and other tested functions to reduce the amount of boilerplate.


http://reviews.llvm.org/D19941





More information about the cfe-commits mailing list