[PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Tue May 10 14:49:03 PDT 2016


thakis added a subscriber: thakis.

================
Comment at: lib/Driver/MSVCToolChain.cpp:477
@@ +476,3 @@
+  std::vector<char> VersionBlock(VersionSize);
+  if (!::GetFileVersionInfoA(ClExe.c_str(), 0, VersionSize,
+                             VersionBlock.data())) {
----------------
We already stat a bunch of directories to find the sdk include path. Can we use the result of that instead of looking at cl.exe? Then we wouldn't have to do additional stats.


http://reviews.llvm.org/D20136





More information about the cfe-commits mailing list