[PATCH] D19846: [clang-tidy] Lift parsing of sequence of names functions to utils.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Tue May 10 06:52:12 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

Looks good with one nit. Thank you!


================
Comment at: clang-tidy/utils/OptionsUtils.h:21
@@ +20,3 @@
+/// \brief Parse a semicolon separated list of strings.
+std::vector<std::string> parseStrings(StringRef Option);
+
----------------
On the second thought, `parseStrings` is too vague. Maybe makes sense to rename to `parseStringList` (and `serializeStringList`).


http://reviews.llvm.org/D19846





More information about the cfe-commits mailing list