[PATCH] D19780: Output OpenCL version in Clang diagnostics

Vedran Miletić via cfe-commits cfe-commits at lists.llvm.org
Fri May 6 08:01:14 PDT 2016


rivanvx added inline comments.

================
Comment at: lib/Parse/ParseDecl.cpp:3519
@@ +3518,3 @@
+                                               / 100);
+        const char *VerSpec = (VerMajor + std::string (".") + VerMinor).c_str();
+        Diag(Tok, DiagID) << VerSpec << PrevSpec << isStorageClass;
----------------
Anastasia wrote:
> I think it will be nicer to use string (not char*) here too.
Other Spec are const char*, so I did it for consistency. But I don't care either way.


http://reviews.llvm.org/D19780





More information about the cfe-commits mailing list