[PATCH] D19936: Adding omitted column to invalid loc diagnostic.

Ben Craig via cfe-commits cfe-commits at lists.llvm.org
Wed May 4 14:06:26 PDT 2016

bcraig created this revision.
bcraig added reviewers: olista01, t.p.northover.
bcraig added a subscriber: cfe-commits.

note_fe_backend_invalid_loc expects three arguments (file, line, column), and will assert when only given two.  The other two places in this file that use note_fe_backend_invalid_loc already supply the Column for the third parameter.



Index: lib/CodeGen/CodeGenAction.cpp
--- lib/CodeGen/CodeGenAction.cpp
+++ lib/CodeGen/CodeGenAction.cpp
@@ -454,7 +454,7 @@
     // we could not translate this location. This can happen in the
     // case of #line directives.
     Diags.Report(Loc, diag::note_fe_backend_invalid_loc)
-        << Filename << Line;
+        << Filename << Line << Column;
   return Loc;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19936.56201.patch
Type: text/x-patch
Size: 444 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160504/1a17037f/attachment-0001.bin>

More information about the cfe-commits mailing list