[PATCH] D19909: [Attr] Add support for the `ms_hook_prologue` attribute.

[Aaron Ballman via cfe-commits]

aaron.ballman added a comment.

Generally, I think this should make use of the patchable function functionality from http://reviews.llvm.org/D19046 when lowering, but I do have some comments on the attribute itself as well.


================
Comment at: include/clang/Basic/Attr.td:2032
@@ -2031,1 +2031,3 @@
 
+def MSHookPrologue : InheritableAttr {
+  let Spellings = [GCC<"ms_hook_prologue">];
----------------
Does this attribute appertain to all targets, or only targets that MSVC supports?

================
Comment at: include/clang/Basic/Attr.td:2035
@@ +2034,3 @@
+  let Subjects = SubjectList<[Function]>;
+  let Documentation = [Undocumented];
+}
----------------
Please, no undocumented new attributes.


http://reviews.llvm.org/D19909