[PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

[Haojian Wu via cfe-commits]

hokein added a comment.

Not sure whether this is what @klimek expected..

You also need to update the FindAllSymbolsTests code (there is a CreateSymbolInfo function there).


================
Comment at: include-fixer/find-all-symbols/SymbolInfo.cpp:91
@@ +90,3 @@
+void SymbolInfo::SetCommonInfo(const std::string &Name,
+                            SymbolKind Kind, const std::string &FilePath,
+                            const std::vector<Context> &Contexts,
----------------
code indentation.

================
Comment at: include-fixer/find-all-symbols/SymbolInfo.cpp:105
@@ +104,3 @@
+    const FunctionInfo &FuncInfo) {
+
+  SymbolInfo Ret;
----------------
A extra blank line.

================
Comment at: include-fixer/find-all-symbols/SymbolInfo.cpp:115
@@ +114,3 @@
+    const std::vector<Context> &Contexts, int LineNumber) {
+
+  SymbolInfo Ret;
----------------
The same.

================
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:91
@@ +90,3 @@
+  static SymbolInfo
+  CreateFunctionSymbolInfo(const std::string &Name, const std::string &FilePath,
+                           const std::vector<Context> &Contexts, int LineNumber,
----------------
Use llvm::StringRef instead of `std::string&`.


http://reviews.llvm.org/D19913