[PATCH] D19869: Added XrefsDBManager into include-fixer and made XrefsDB return SymbolInfo.

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Tue May 3 12:31:04 PDT 2016

ioeric added inline comments.

Comment at: include-fixer/IncludeFixer.h:34-35
@@ -33,3 +33,4 @@
-      XrefsDB &Xrefs, std::vector<clang::tooling::Replacement> &Replacements,
+      XrefsDBManager &XrefsDBMgr,
+      std::vector<clang::tooling::Replacement> &Replacements,
       bool MinimizeIncludePaths = true);
klimek wrote:
> That seems unexpected. Why is the XrefsDBManager in the business of doing SymbolInfo -> include path mappings?
Since the mapping was done in XrefsDB before, I kept the way it was. Migrating SymbolInfo -> Include path mappings into IncludeFixer will be the next step, and I'll need to discuss with Ben about where exactly we want to place it.


More information about the cfe-commits mailing list