[PATCH] D19881: clang-cl: Print a blank line at the start of /showIncludes (PR27226)

Brad King via cfe-commits cfe-commits at lists.llvm.org
Tue May 3 11:34:26 PDT 2016


brad.king added a comment.

I do not think MSVC starts off with an empty line with -showIncludes specifically.  It is just that MSVC unconditionally prints the name of the source file first.  This means that any showIncludes output is naturally preceded by a newline because at least one other line was printed first.  If clang-cl is to have compatible output with MS cl then it should print the source file name first too.  However, that would be a broader decision that should stand on its own.

IMO the motivating use case is simply a bug in CMake and clang-cl should not have to adapt to it.  There is already a workaround available for existing clang-cl/CMake release combinations.  CMake nightly binaries will be available starting tonight with the fix, and the CMake 3.6 release will have the fix too.


http://reviews.llvm.org/D19881





More information about the cfe-commits mailing list