[PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue May 3 08:41:06 PDT 2016


aaron.ballman added inline comments.

================
Comment at: include/clang/AST/ASTContext.h:824
@@ -823,1 +823,3 @@
   unsigned overridden_methods_size(const CXXMethodDecl *Method) const;
+  const ArrayRef<const CXXMethodDecl *> overridden_methods(
+      const CXXMethodDecl *Method) const;
----------------
This is too tight of a coupling to the underlying datatype. It should return `iterator_range<overridden_cxx_method_iterator>`

================
Comment at: include/clang/AST/DeclCXX.h:1830
@@ -1829,2 +1829,3 @@
   unsigned size_overridden_methods() const;
+  const ArrayRef<const CXXMethodDecl *> overridden_methods() const;
 
----------------
This should return `iterator_range<method_iterator>`


http://reviews.llvm.org/D19324





More information about the cfe-commits mailing list