[PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Mon May 2 23:22:40 PDT 2016


EricWF added a comment.

In http://reviews.llvm.org/D19835#419547, @mclow.lists wrote:

> How about not using XFAIL?
>  Instead, just test for those two conditions.
>
> Psuedo-code:
>
>   #if defined(GLIBC)
>   #if GLIBC < 226
>   #error
>   #elif TEST_STD_VER >= 11
>   #error
>   #endif.


Because I want this test to pass, not fail. I definitely don't want to force failure of a passing test.
(Also it's not really that easy to test the GLIBC version.)


http://reviews.llvm.org/D19835





More information about the cfe-commits mailing list