[PATCH] D19412: [libcxx] Refactor pthread usage - II

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Mon May 2 19:21:18 PDT 2016


EricWF added a comment.

In http://reviews.llvm.org/D19412#417729, @rmaprath wrote:

> So, perhaps it is best to leave these pthread mutexes alone, purely for performance reasons. We'll have to excuse a couple of `#ifdef _LIBCPP_THREAD_API_XXXX` conditionals in the library sources to allow the external threading API to function.
>
> Does that sound like an OK compromise? @EricWF, @mclow.lists?


Sounds good to me.  Although we should probably change these from `pthread_mutex_t` to `__libcpp_mutex_t`.


http://reviews.llvm.org/D19412





More information about the cfe-commits mailing list