[PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon May 2 11:39:29 PDT 2016


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM with a commenting request.


================
Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342
@@ +341,3 @@
+
+template <typename T>
+class PositiveSelfInitialization : NegativeAggregateType
----------------
hokein wrote:
> aaron.ballman wrote:
> > Is it required to be a templated class to trigger the crash?
> Yes, it's required.
Then some comments in this test would be good, I would assume otherwise from just looking at the test.


http://reviews.llvm.org/D19802





More information about the cfe-commits mailing list