[PATCH] D18088: Add a new warning to notify users of mismatched SDK and deployment target

[Chris Bieneman via cfe-commits]

beanz added a comment.

Thanks!

Will commit soon.


================
Comment at: lib/Driver/ToolChains.cpp:733
@@ +732,3 @@
+      StringRef SDKName = SDK.slice(0, StartVer);
+      if (!SDKName.startswith(getPlatformFamily()))
+        getDriver().Diag(diag::warn_incompatible_sysroot)
----------------
rsmith wrote:
> I assume it's intentional that you allow targeting FooOS with a sysroot for FooSimulator and vice versa?
Yes. It turns out that setting the iOS version min flag when using the simulator SDK is *way* too common of a case to warn about, and since it all turns into the same load command anyways it doesn't matter too much.


http://reviews.llvm.org/D18088