[PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

[Anastasia Stulova via cfe-commits]

Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.

LGTM! Apart from small comments that can be addressed directly before committing.


================
Comment at: include/clang/Basic/OpenCLExtensions.def:18
@@ +17,3 @@
+#else
+#define OPENCLEXT_INTERNAL(ext, ...) OPENCLEXT(ext)
+#endif // OPENCLEXT
----------------
Could you add a brief comment explaining usage of both macros.

================
Comment at: test/CodeGenOpenCL/builtins-r600.cl:2
@@ -1,3 +1,3 @@
 // REQUIRES: amdgpu-registered-target
-// RUN: %clang_cc1 -triple r600-unknown-unknown -S -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple r600-unknown-unknown -target-cpu rv670 -S -emit-llvm -o - %s | FileCheck %s
 
----------------
Just triple is not sufficient here? 

================
Comment at: test/SemaOpenCL/extensions.cl:14
@@ +13,3 @@
+#ifdef NOFP64
+// expected-warning at -2{{unknown OpenCL extension 'cl_khr_fp64' - ignoring}}
+#endif
----------------
I was just wondering whether renaming to "unsupported" instead of "unknown" would make more sense?


http://reviews.llvm.org/D19484