[PATCH] D19698: [libcxx] [test] Need to include <memory> for std::unique_ptr.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 18:02:38 PDT 2016


EricWF added a comment.

In http://reviews.llvm.org/D19698#416306, @rsmith wrote:

> In http://reviews.llvm.org/D19698#416255, @Eugene.Zelenko wrote:
>
> > It'll be good idea to run Include What You Use <https://github.com/include-what-you-use/include-what-you-use> to make sure that all dependencies are explicit.
>
>
> You can also remove all the `export *`s from the module map and try running the testsuite with modules enabled for a nasty shock about how common this problem is...


Most tests pretty much rely on <type_traits> getting dragged in indirectly, same thing with <memory> and the bits of <utility> we actually define in <type_traits>.

I was hoping that maybe "Include What You Use" had a fix-it mode. I'll look into this further tonight.


http://reviews.llvm.org/D19698





More information about the cfe-commits mailing list