[PATCH] D18136: boost-use-to-string check

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 12:00:58 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

Looks good with a couple of nits. Please submit this as a single patch, there's no need to add an empty "boost" module separately.


================
Comment at: clang-tidy/boost/UseToStringCheck.cpp:38
@@ +37,3 @@
+          argumentCountIs(1), unless(isInTemplateInstantiation()))
+          .bind("to_string"),
+      this);
----------------
clang-format?

================
Comment at: clang-tidy/boost/UseToStringCheck.h:19
@@ +18,3 @@
+
+/// Matches calls to boost::lexical_cast<std::string> and
+/// boost::lexical_cast<std::wstring> and replaces it with to_string and
----------------
1. Please enclose inline code snippets in backquotes.
2. s/Matches/Finds/ or Flags
3. s/and replaces it/and replaces them
4. s/to_string/std::to_string/, same for to_wstring.


http://reviews.llvm.org/D18136





More information about the cfe-commits mailing list