r267534 - [MSVC] PR27337: allow static_cast from private base to derived for WTL

Dmitry Polukhin via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 03:15:03 PDT 2016


Reverted in r267865.

On Wed, Apr 27, 2016 at 10:31 PM, Dmitry Polukhin <dmitry.polukhin at gmail.com
> wrote:

> So it seems that there is an agreement that Clang don't need this MSVC
> "feature" so I'll revert my patch tomorrow when I get to the office.
>
> On Wed, Apr 27, 2016 at 10:09 PM, Stephan T. Lavavej <
> stl at exchange.microsoft.com> wrote:
>
>> [Richard Smith]
>> > You can find a description of the problem in http://llvm.org/PR27337
>> > Brief summary:
>> > The WTL bug is the missing 'public' on the second base class on this
>> line:
>> https://sourceforge.net/p/wtl/code/HEAD/tree/trunk/wtl/Samples/MDIDocVw/mainfrm.h#l636
>> > The C1xx bug is that it accepts a (non-C-style) cast from a base class
>> to an inaccessible derived class.
>>
>> Thanks, I've asked my boss if MS devs still maintain WTL and if so, who.
>>
>> As for C1XX, I've filed VSO#216958 "C1XX shouldn't allow static_cast to
>> bypass private inheritance" with a self-contained repro.
>>
>> STL
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160428/4a737e2f/attachment-0001.html>


More information about the cfe-commits mailing list