[PATCH] D18136: boost-use-to-string check

[Alexander Kornienko via cfe-commits]

alexfh requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: clang-tidy/boost/BoostTidyModule.cpp:26
@@ -22,3 +25,3 @@
 
   ClangTidyOptions getModuleOptions() override {
     ClangTidyOptions Options;
----------------
This method doesn't do anything, please remove it.

================
Comment at: clang-tidy/boost/UseToStringCheck.cpp:37
@@ +36,3 @@
+                                  isStrictlyInteger()))))))),
+          argumentCountIs(1), unless(hasParent(isInTemplateInstantiation())))
+          .bind("to_string"),
----------------
Why do you need `hasParent()` around `isInTemplateInstantiation()`?

================
Comment at: clang-tidy/boost/UseToStringCheck.cpp:68
@@ +67,3 @@
+                                    Call->getArg(0)->getExprLoc()),
+      (llvm::Twine("std::to_") + StringType + llvm::Twine("(")).str());
+}
----------------
No need for the second `llvm::Twine`.

================
Comment at: docs/clang-tidy/checks/boost-use-to-string.rst:12
@@ +11,3 @@
+overloads, because it would change the behaviour.
+
+
----------------
Please remove one empty line.


http://reviews.llvm.org/D18136