[PATCH] D19412: [libcxx] Refactor pthread usage - II

Ben Craig via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 07:08:17 PDT 2016


bcraig added a subscriber: bcraig.

================
Comment at: src/mutex.cpp:31
@@ +30,3 @@
+#else
+    #error "Not implemented for the selected thread API."
+#endif
----------------
Can't we just check for _LIBCPP_THREAD_API_PTHREAD once at the top of the file and #error as necessary there?  I don't get the value of multiple #errors for the same condition, but sprinkled throughout the implementation.  I do see the cost in the strategy, in that there are now lots of places that can bit-rot.


http://reviews.llvm.org/D19412





More information about the cfe-commits mailing list