[PATCH] D19451: [clang-tidy] New checker for redundant expressions.

Etienne Bergeron via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 23 09:33:04 PDT 2016


etienneb added a comment.

> Will check catch more complicated cases, like


[..]

It is not "yet" catching these cases:

if ((Point2.x > Point1.x) && (Point1.x < Point2.x)) ?

I believe the AreEquivalentExpression should be extended, and probably llifted to utils.
Here again, I propose to do it incrementally.

An other nice extension is to catch cases like:

  (x | y | x)

In this case, you need to implement the associative operators.


http://reviews.llvm.org/D19451





More information about the cfe-commits mailing list