[PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

John McCall via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 22 11:23:46 PDT 2016


rjmccall added inline comments.

================
Comment at: lib/Frontend/CompilerInstance.cpp:763
@@ -762,8 +762,3 @@
       Includers.push_back(std::make_pair(FindFile, FindFile->getDir()));
-      File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false,
-                            /*FromDir=*/nullptr,
-                            /*CurDir=*/UnusedCurDir, Includers,
-                            /*SearchPath=*/nullptr,
-                            /*RelativePath=*/nullptr,
-                            /*RequestingModule=*/nullptr,
-                            /*SuggestedModule=*/nullptr, /*SkipCache=*/true);
+      if (HS)
+        File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false,
----------------
What's the justification for this one?


http://reviews.llvm.org/D19385





More information about the cfe-commits mailing list